-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweaks #30
Tweaks #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like some BC so this will be a new major version
@@ -1,17 +0,0 @@ | |||
[package] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the reason behind removing this file? I was using it to run at least minimal tests before releasing new version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can still do that... use cargo run --example simple
and it should just work. Or, if you want to keep it as a separate crate, it should be a directory nested inside examples
that contains a main.rs
and the Cargo.toml
. The way it was set up resulted in cargo check --all-targets
failure, because examples/simple.rs
is actually part of the top-level crate, but the top-level crate did not have the necessary dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for explanation, looks good I'll merge it now
No description provided.