Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks #30

Merged
merged 12 commits into from
Aug 4, 2021
Merged

Tweaks #30

merged 12 commits into from
Aug 4, 2021

Conversation

djc
Copy link
Owner

@djc djc commented Aug 3, 2021

No description provided.

@djc djc marked this pull request as ready for review August 3, 2021 08:38
Copy link
Collaborator

@hrvolapeter hrvolapeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like some BC so this will be a new major version

@@ -1,17 +0,0 @@
[package]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the reason behind removing this file? I was using it to run at least minimal tests before releasing new version

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can still do that... use cargo run --example simple and it should just work. Or, if you want to keep it as a separate crate, it should be a directory nested inside examples that contains a main.rs and the Cargo.toml. The way it was set up resulted in cargo check --all-targets failure, because examples/simple.rs is actually part of the top-level crate, but the top-level crate did not have the necessary dependencies.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explanation, looks good I'll merge it now

@hrvolapeter hrvolapeter merged commit 04eb69a into master Aug 4, 2021
@hrvolapeter hrvolapeter deleted the tweaks branch August 4, 2021 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants