Errors and logs #47
Merged
Errors and logs #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Jan 20, 2022
src/lib.rs
Outdated
| @@ -145,5 +152,6 @@ async fn get_authentication_manager( | |||
| /// | |||
| /// Returns `AuthenticationManager` which can be used to obtain tokens | |||
| pub async fn init() -> Result<AuthenticationManager, Error> { | |||
| log::debug!("initialising gcp_auth"); | |||
There was a problem hiding this comment.
Nit: make this Initializing... to (a) make capitalization consistent with the other log messages you've added and (b) use US spelling?
There was a problem hiding this comment.
heh, I tend to prefer UK spelling but sure :)
|
Sorry, would you mind squashing the last commit into the first one? I'd like to rebase a nice commit history. |
added 2 commits
January 20, 2022 15:22
This makes the std::error::Error::source() report the original error, allowing "reporting types" like anyhow::Error to display the entire error chain nicely.
No worries, done. I like keeping squashing till the very last usually, I also wish github would support at least fixup commits and autosquash or maybe even interactive rebase and merge. Oh well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wires up Error::source and adds a little more debug logging. Both are very helpful to understand what is going on.