Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capability "IMAP4REV1" is not accepted as valid #54

Closed
link2xt opened this issue Sep 3, 2019 · 1 comment · Fixed by #55
Closed

Capability "IMAP4REV1" is not accepted as valid #54

link2xt opened this issue Sep 3, 2019 · 1 comment · Fixed by #55

Comments

@link2xt
Copy link
Contributor

link2xt commented Sep 3, 2019

Since PR #47 parser requires IMAP4rev1 capability to be present. Some IMAP servers send IMAP4REV1 string instead: https://www.communigate.com/pub/Guide_516.pdf, p. 149

It results in parse error, so I can't connect to such servers with imap crate, which uses imap-proto parser.

According to RFC3501 "Except as noted otherwise, all alphabetic characters are case-insensitive.".

Thunderbird and mutt accept IMAP4REV1.
@avitex
Copy link
Contributor

avitex commented Sep 4, 2019

I'll submit a PR to fix this today

This was referenced Sep 4, 2019
Merged
Merged
@djc djc closed this as completed in #55 Sep 4, 2019
link2xt pushed a commit to link2xt/tokio-imap that referenced this issue Sep 4, 2019
Add IMAP4REV1 test case
41ab93f 
Test that "IMAP4rev1" capability is matched case-insensitive

See issue djc#54
This was referenced Sep 4, 2019
Merged
Merged
Closed
djc pushed a commit that referenced this issue Sep 4, 2019
@djc
Add IMAP4REV1 test case
9683d5f 
Test that "IMAP4rev1" capability is matched case-insensitive

See issue #54
@link2xt link2xt mentioned this issue Sep 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make token matches case-insensitive
2 participants
@avitex @link2xt