Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mu4e rfe] Ability to disable the global mode-line tweaks #2463

Closed
nbarrientos opened this issue Apr 3, 2023 · 4 comments · Fixed by #2468
Closed

[mu4e rfe] Ability to disable the global mode-line tweaks #2463

nbarrientos opened this issue Apr 3, 2023 · 4 comments · Fixed by #2468
Labels
mu4e specific for mu4e rfe

Comments

@nbarrientos
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Whereas I enjoy having some segments in the mode-line of the headers buffer I'd rather mu4e to not to maintain any "global mode-line". This is because I have my own new mail indicators already. I checked in the manual (sections 13.2.x) and it does not seem possible to disable the global mode-line. It'd be nice if this was configurable.

Describe the solution you'd like

A defcustom in mu4e-modeline.el to prevent mu4e from touching the global mode-line.

@nbarrientos nbarrientos added mu4e specific for mu4e new rfe labels Apr 3, 2023
@djcb
Copy link
Owner

djcb commented Apr 4, 2023

I won't be working on this, but if you have very small change to mu4e-modeline to this, we can consider it.

@djcb djcb removed the new label Apr 4, 2023
@nbarrientos
Copy link
Contributor Author

Would you be happy with simply not registering it during mu4e--start?

@@ -132,7 +132,8 @@ defun mu4e--start
     (add-hook 'mu4e-query-items-updated-hook #'mu4e--notification))
   ;; modeline support
   (when mu4e-modeline-support
-    (mu4e--modeline-register #'mu4e--bookmarks-modeline-item 'global)
+    (when mu4e-modeline-global
+      (mu4e--modeline-register #'mu4e--bookmarks-modeline-item 'global))
     (mu4e-modeline-mode)
     (add-hook 'mu4e-query-items-updated-hook #'mu4e--modeline-update))
   (mu4e-modeline-mode (if mu4e-modeline-support 1 -1))

The patch would be the hunk above, the new defcustom in mu4e-modeline (default t) and a line in the documentation in section 13.2 explaining that the global mode-line can be disabled.

@djcb
Copy link
Owner

djcb commented Apr 4, 2023

Sure, thanks, guess that should work. Did you test it? :-)

@nbarrientos
Copy link
Contributor Author

Sure, thanks, guess that should work. Did you test it? :-)

Thanks. I've decided to take another (better, IMO) path, please take a look at the PR. The order of magnitude of the patch hasn't changed much 😄

nbarrientos added a commit to nbarrientos/mu that referenced this issue Apr 5, 2023
@djcb djcb closed this as completed in #2468 Apr 6, 2023
djcb pushed a commit that referenced this issue Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mu4e specific for mu4e rfe
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants