-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new maildir section in the homepage. #2496
Conversation
Thank you for the effort/PR! However, I don't want an extra maildir-section in the main view. TBH, I don't see much value in having maildir shortcuts without a shortcut; even if you don't use them, you can still add some shortcut. You could even give all of the same binding, e.g., Maybe we could support key-less shortcuts directly in the normal Maildirs section, but not convinced it's worth the extra code. |
What I was looking for is to have one section in the home view with all the maildirs I have, even if they don't have shortcuts, because I want to know which maildirs have new emails even if I don't have defined a shortcut. I have over 100 maildirs that I don't check daily, and it seems kind of hacky to assign the same key binding to all of them, apart that it's clearer for me to have a first section of my daily maildirs and a second section with the rest of maildirs. If you don't want to add this new section to the home view is ok, I can maintain it in my local changes without problem :). |
ab9d60b
to
afd4372
Compare
afd4372
to
8c43b9c
Compare
8c43b9c
to
4add158
Compare
4add158
to
222e827
Compare
222e827
to
ee8b255
Compare
ee8b255
to
bdc36c0
Compare
Unless things have changed, assigning the same shortcut to every maildir results in the jumplist shown in the minibuffer being very ugly. Something like: I'm not too picky with regards to if it should be a separate section or inline with another section, but I think this would probably be yet another time someone has wanted this and @djcb doesn't. I'm among the number wanting something like this for similar purposes, displaying a count of read/unread and path basically. Keep in mind the image below is from my own "patched" version and it's likely my hack is uglier than this PR, but something like the below where you have hundreds of maildirs makes it easier to see which boxes have new/unread: |
46fc13d
to
c2ddc50
Compare
c2ddc50
to
fce27e4
Compare
fce27e4
to
bdd7947
Compare
bdd7947
to
bd0ab56
Compare
…draft message. Signed-off-by: Ritho <palvarez@ritho.net>
Since not all the maildirs have a shortcut defined, and the user might want to see more than the maildirs with a shortcut in their home, we add a new maildir section in the homepage to see all the defined maildirs to show. The list of maildirs to be shown are defined in the new custm mu4e-maildirs variable. Signed-off-by: Ritho <palvarez@ritho.net>
bd0ab56
to
f718fac
Compare
Since not all the maildirs have a shortcut defined, and the user might want to see more than the maildirs with a shortcut in their home, we add a new maildir section in the homepage to see all the defined maildirs to show. The list of maildirs to be shown are defined in the new custm mu4e-maildirs variable.