Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

Replace HCL parsing library #151

Merged
merged 1 commit into from
Jul 24, 2017
Merged

Replace HCL parsing library #151

merged 1 commit into from
Jul 24, 2017

Conversation

msessa
Copy link
Collaborator

@msessa msessa commented Jul 23, 2017

This PR fixes #150 by replacing the hcl-to-json library with gopher-hcl which handles a dot character in the path section correctly.

gopher-hcl acts a drop-in replacement and so it requires minimal code changes

@msessa msessa added the bug label Jul 23, 2017
@msessa msessa requested a review from djenriquez July 23, 2017 02:31
@msessa msessa mentioned this pull request Jul 23, 2017
Closed
djenriquez
djenriquez approved these changes Jul 24, 2017
View reviewed changes
Copy link
Owner

@djenriquez djenriquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msessa msessa merged commit d2412ef into djenriquez:master Jul 24, 2017
@msessa msessa deleted the bugfix/hcl-json-dot branch July 24, 2017 23:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@djenriquez djenriquez djenriquez approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parse policy path failed
2 participants
@msessa @djenriquez