Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push image to Docker Hub #31

Open
meeDamian opened this issue Feb 9, 2019 · 5 comments
Open

Push image to Docker Hub #31

meeDamian opened this issue Feb 9, 2019 · 5 comments

Comments

@meeDamian
Copy link
Collaborator

Since Dockerfile is already provided, why not also push it to Docker Hub to make using it easier?

Note that both Docker Hub and Travis are able to build and push it automatically on a push to master or git tag.

@meeDamian
Copy link
Collaborator Author

Happy to setup Docker Hub pipeline if I get (even temporarily) added as a collaborator here.

@djmelik
Copy link
Owner

djmelik commented Mar 4, 2019

Just sent you an invite, thanks for your help!

@meeDamian
Copy link
Collaborator Author

Thanks! I'll get to it soon :)

@meeDamian
Copy link
Collaborator Author

Okay…

  1. I'm sorry I accidentally pushed straight to master here - I confused remotes 🙈

  2. @djmelik as it's probably better to have Docker tag the same as Github path, there's one thing you need to do:

    1. Go to: https://travis-ci.org/djmelik/lndash/settings

    2. Fill-in your Docker credentials as on the picture below:

      MacOS 2019-03-23 at 01 17 44
    3. If your Docker username is different than djmelik, you also need to adjust these things

Once you complete that, Travis should test all pushes to master and push them forward to Docker Hub as :latest tag. Each git tag will also get Docker-tagged accordingly.

@meeDamian
Copy link
Collaborator Author

Alternatively, I can set it up if you create and add me as a collaborator to Docker Hub https://hub.docker.com/r/djmelik/lndash as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants