-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New source assembly line, with build script #85
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New script to break out the layers into final UFO sources.
… the tracking value itself
…, but also exists 'normally'
Assemble tools for assembleSources.py and assembleRotatedSources.py
Closed
I think we should squash & merge this PR, and refine/improve in subsequent PRs. Any objections? @martelahaie |
No objections at all |
3 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds three new Python scripts that takes the layered source UFOs from
sources/1-drawing
as inputs, and exports assembled UFOs ready to make the various binary fonts, including the COLRv0 font and the new-ish "Spice" COLRv1 font.It also adds a shell script that runs the above scripts and then builds the final fonts using fontmake.
The main idea is to deprecate all UFOs in
sources/2-build
, as they are largely derived from the UFOs insources/1-drawing
.Our aim is to stay compatible with the currently released fonts as much as possible, but there are still some open issues that I think we should address separately.
One issue is with Bungee Basic Shade, which has some manual changes in the
sources/2-build
files compared to thesources/1-drawing
sources. I'm looking into a way to integrate those into the sources cleanly.The number of commits in this PR is quite high, and there was one mistake commit with a lot of files, so I think I will squash all changes into one clean commit when merging.
A lot of this work was done by @martelahaie.
This implements #76.
This fixes #87 and fixes #90.