Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New source assembly line, with build script #85

Merged
merged 37 commits into from
Sep 18, 2023

Conversation

justvanrossum
Copy link
Collaborator

@justvanrossum justvanrossum commented Sep 30, 2022

This PR adds three new Python scripts that takes the layered source UFOs from sources/1-drawing as inputs, and exports assembled UFOs ready to make the various binary fonts, including the COLRv0 font and the new-ish "Spice" COLRv1 font.

It also adds a shell script that runs the above scripts and then builds the final fonts using fontmake.

The main idea is to deprecate all UFOs in sources/2-build, as they are largely derived from the UFOs in sources/1-drawing.

Our aim is to stay compatible with the currently released fonts as much as possible, but there are still some open issues that I think we should address separately.

One issue is with Bungee Basic Shade, which has some manual changes in the sources/2-build files compared to the sources/1-drawing sources. I'm looking into a way to integrate those into the sources cleanly.

The number of commits in this PR is quite high, and there was one mistake commit with a lot of files, so I think I will squash all changes into one clean commit when merging.

A lot of this work was done by @martelahaie.

This implements #76.

This fixes #87 and fixes #90.

martelahaie and others added 30 commits September 23, 2022 16:24
New script to break out the layers into final UFO sources.
Assemble tools for assembleSources.py and assembleRotatedSources.py
@justvanrossum justvanrossum mentioned this pull request Aug 11, 2023
@justvanrossum
Copy link
Collaborator Author

justvanrossum commented Sep 18, 2023

I think we should squash & merge this PR, and refine/improve in subsequent PRs. Any objections? @martelahaie

@martelahaie
Copy link
Collaborator

No objections at all

@justvanrossum justvanrossum merged commit 965d5d9 into djrrb:master Sep 18, 2023
@justvanrossum justvanrossum deleted the assemble-sources branch September 18, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bungee Spice colors reversed from Google Fonts release Invalid type flags in the OS/2 and Windows table
2 participants