Don't access caml values without acquired runtime #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
July 10, 2016 23:01
who have their own swap32 macros.
We mustn't access the context in a custom block while the runtime is released. It might be relocated from minor to major heap or during major heap compaction. Also include string.h for memcpy().
which is now called update_buffer. It was not exported in the .mli anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mustn't access the context in a custom block while the runtime is released.
It might be relocated from minor to major heap or during major heap compaction. This is very probable if the context has just recently been allocated on the minor heap.
The work of copying the context is hopefully only a small overhead when checksumming over probably huge bigarrays.
Also include
string.hformemcpy()and fix building on BSDs.