Goswin's patches from Debian #6
Conversation
Change file functions so it can release the runtime system while calculating checksum of a file. Also add O_CLOEXEC to prevent filedescriptors leaking when another thread calls exec. Author: Goswin von Brederlow <goswin-v-b@web.de>
This patch exposes the context and provides incremental update functions for strings. Author: Goswin von Brederlow <goswin-v-b@web.de> Missing bindings for 'zero: t' guesstimated by: David Scott <dave.scott@eu.citrix.com>
This patch adds a function to copy a context. Author: Goswin von Brederlow <goswin-v-b@web.de>
This patch renames the update function to unsafe_update_substring and introduces new functions update_string and update_substring that include range checks. Author: Goswin von Brederlow <goswin-v-b@web.de>
These were originally in 0006-update-and-bigarray-support.patch but went missing in the split patchset. Original description: Support for update and bigarray This patch exposes the context and provides incremental update functions for strings and bigarrays. The bigarray functions run without holding the global lock and the file function is also changed to run without the global lock. This enables other threads to run concurrently while the sha checksum is being computed. Author: Goswin von Brederlow <goswin-v-b@web.de> Signed-off-by: David Scott <dave.scott@eu.citrix.com>
|
Thanks for putting this in a pull request form. I'm not sure what to do with this package though, as it's technically superseded by cryptohash, but i've haven't ported the package to ocaml yet. In any case, i'll reuse the .ml / .mli file as templates anyhow, so it's good they are updated. |
|
actually i've added a old version i've worked on https://github.com/vincenthz/ocaml-cryptohash |
|
Thanks for merging. It sounds like you're a bit in-between crypto libraries! Thanks for tagging a release too-- I was just about to ask you about that :) I'd like to use the sha1 implementation in a XenServer tool so it's handy to have a release to reference... |
|
I've made a PR to release 1.9 in opam: |
I've reconstructed Goswin von Brederlow's patches on
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=663520#20
Unfortunately there were some hunks missing (in particular defining "zero") so I improvised. Hopefully I've not broken it too badly. What do you think?
Fixes #1