Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate sbt-explicit-dependencies #24

Merged
merged 2 commits into from
Nov 22, 2020
Merged

Integrate sbt-explicit-dependencies #24

merged 2 commits into from
Nov 22, 2020

Conversation

rossabaker
Copy link
Contributor

@rossabaker rossabaker commented Nov 22, 2020 •
edited
Loading

Fixes #19.

rossabaker
rossabaker commented Nov 22, 2020
View reviewed changes
core/src/main/scala/sbtspiewak/SpiewakPlugin.scala
Comment on lines +493 to +495
unusedCompileDependenciesFilter -=
moduleFilter("org.scala-js", "scalajs-library*") |
moduleFilter("org.scala-lang", "scala3-library*"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an upstream problem to me?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to agree

@rossabaker rossabaker mentioned this pull request Nov 22, 2020
Closed
@djspiewak djspiewak merged commit 51dd809 into djspiewak:master Nov 22, 2020
@djspiewak djspiewak mentioned this pull request Nov 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djspiewak djspiewak djspiewak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explore sbt-explicit-dependencies
2 participants
@rossabaker @djspiewak