Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: links preview of review text #1

Merged
merged 4 commits into from
Apr 24, 2024
Merged

fix: links preview of review text #1

merged 4 commits into from
Apr 24, 2024

Conversation

pseudoyu
Copy link
Contributor

@pseudoyu pseudoyu commented Apr 24, 2024

When daily review text has links, it will show the markdown syntax like:

link_preview_before

this pr fixes it using markdown-it and fits well in all themes using daisy-ui.

link_preview_after

@djyde
Copy link
Owner

djyde commented Apr 24, 2024

Nice! But I prefer using a markdown parser library instead of writing regexp.

@djyde djyde merged commit c9b60da into djyde:main Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants