Use JSON specs for implementing grill features. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update grills.json with new data and structure.
This also allows us to execute the JavaScript snippets in each definition, which reduces the need for a bunch of duplicated code in api.py.
This also removes our decoding implementation and uses the JS functions from the specs instead. Additional grill functions are also added. BREAKING: The state and temperature dicts have once again been merged so we can just return the same dict that the JS returns.
dknowles2
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the implementation to use JSON specifications for grills retrieved from the Dansons API server. The JSON specs not only have metadata about each grill model, but also include the hex command codes for grill functions, and some JavaScript snippets that perform various translations. We utilize js2py to execute these JavaScript snippets so that our library executes the same code that the mobile apps do.
There are breaking changes involved here:
api.PitBossnow requires a second parameter, which is the grill model being controlled. We can't ascertain this from the BLE connection, as this information is not returned from any API call or GATT characteristic.New JSON specs can be retrieved using the new
scripts/dump_grills.pyscript.