Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add man-page for feedgnuplot #34

Closed
wants to merge 1 commit into from
Closed

Add man-page for feedgnuplot #34

wants to merge 1 commit into from

Conversation

TomTheBear
Copy link

We use feedgnuplot in https://github.com/RRZE-HPC/likwid. For the integration into the Debian package repository we needed a man page for all executables we ship. Feedgnuplot is one of those, so I created a man page. Feel free to add it to your repository. The version and date of last changelog change are hardcoded because I don't know how to add them in your Makefile.PL to adjust them automatically at build time.

@dkogan
Copy link
Owner

dkogan commented May 2, 2018

Hi. I'm not sure why this would be needed. First off, there's already a Debian package:

https://packages.debian.org/sid/feedgnuplot

And this package already has a manpage:

https://packages.debian.org/sid/all/feedgnuplot/filelist

This manpage is built by the build system:

dima@shorty:~/projects/feedgnuplot$ perl Makefile.PL

Generating a Unix-style Makefile
Writing Makefile for feedgnuplot
Writing MYMETA.yml and MYMETA.json

dima@shorty:~/projects/feedgnuplot$ make

cp bin/feedgnuplot blib/script/feedgnuplot
"/usr/bin/perl" -MExtUtils::MY -e 'MY->fixin(shift)' -- blib/script/feedgnuplot
Manifying 1 pod document

dima@shorty:~/projects/feedgnuplot$ ls -l blib/man1/feedgnuplot.1

-rw-r--r-- 1 dima dima 44782 May 2 09:32 blib/man1/feedgnuplot.1

Does some of this not work for you, or was it not clear how it was supposed to work? I'd like to fix any problems in the build system, but the manpage is generated data, so I don't want to commit it into the repo.

Thanks

@TomTheBear
Copy link
Author

We integrated feedgnuplot in LIKWID already some years ago (even before I started working on it) and there hasn't been a man page for it at that time. Since one of my co-workers thought that he wrote feedgnuplot and didn't create a man page, I created the man page by hand.
Since you don't need it, you can delete the pull request. We only changed the shebangs in all included scripts in LIKWID and I wanted to push them back to the original projects. In issue #28 you made clear that you don't want the env-based shebang, so I just added the man page

@dkogan
Copy link
Owner

dkogan commented May 2, 2018

Hi. I'm definitely interested in people sending me patches, so the effort is absolutely appreciated. Thanks! I think the manpage generation is already handled, so I'm not going to take this one, if that's ok. Do let me know if you have other improvements. I don't reject everything :)

@dkogan dkogan closed this May 2, 2018
@TomTheBear
Copy link
Author

We didn't do other changes to your script. We don't do advanced plotting through feedgnuplot, just default xy plots. Of course, we report back when we do (helpful) changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants