Quote and escape file names in index file and allow whitespaces

[bertogg]

cscope can handle files with whitespaces and other special characters,
but they must be properly quoted and escaped in the index file. This
can be fixed by filtering the output of 'find' through 'sed'.

cscope still complains when a symbol is found in a file with a
whitespace in its name ("File does not have expected format") but at
least it works (partially) now. On the other hand, filenames with
double quotes or backslashes seem to work just fine.

In addition to that, the regular expression that parses the cscope
output needs to be modified to allow whitespaces in file names. The
new regular expression still does not allow tabs in file names, but
they are extremely unlikely to happen and cscope does not seem to
support them anyway.

[dkogan]

Hi. Thanks for the patch. I tried it out, and it doesn't work for me. I made two test directories: one with " and \ and spaces in the filenames, and another with just " and . Both fail with "File does not have expected format". The test directories can both be downloaded here: http://notes.secretsauce.net/xcscope.specialchars.tar.gz

I would C-c s I to index in each one: that worked without complaint. Then I would C-c s g main to find the main symbol in each directory, and this would produce the error in each case. Can you please try on this test directory, or let me know how your test directory differs.

Thanks!

[dkogan]

Actually, never mind. I was testing it wrong. It now looks like it actually does work in both the with-spaces and no-spaces cases. It still says "File does not have expected format", but that looks like a non-breaking warning. Is that your experience?

[bertogg]

Yes, I get that warning but things seem to work (although I think I had a case in which C-c s g <symbol> would not find anything, but wit the test that you uploaded it does work fine).

[bertogg]

Btw, if you prefer a cleaner cscope.files you can also change the last sed parameter like this:

"-e" "/[ \\\\]/s/.*/\"&\"/")) " ") " > "

This way only the filenames with special characters or whitespaces get surrounded by double quotes in cscope.files.

[dkogan]

The patch looks reasonable to me. Thanks! Let me dog-food this for a while, and then do a release.