Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up stuff #192

Closed
4 tasks done
jcklie opened this issue Aug 20, 2021 · 0 comments
Closed
4 tasks done

Clean up stuff #192

jcklie opened this issue Aug 20, 2021 · 0 comments
Assignees
@jcklie
Labels
🆕Enhancement
Milestone
0.6.0

Comments

@jcklie
Copy link
Collaborator

jcklie commented Aug 20, 2021 •
edited by reckart
Loading

Is your feature request related to a problem? Please describe.
Improve code style

Describe the solution you'd like

  • isort black
  • Unused imports
  • type comments to type annotations via com2ann
  • pyupgrade
@jcklie jcklie added this to the 0.6.0 milestone Aug 20, 2021
@jcklie jcklie self-assigned this Aug 20, 2021
@reckart reckart modified the milestones: 0.6.0, 0.7.0 Sep 27, 2021
jcklie added a commit that referenced this issue Sep 29, 2021
@jcklie
#192 - Cleanup stuff
aa00bab 
- Black isort
jcklie added a commit that referenced this issue Sep 29, 2021
@jcklie
#192 - Cleanup stuff
5085a56 
- Optimize import
- Format some XML
jcklie added a commit that referenced this issue Sep 29, 2021
@jcklie
#192 - Cleanup stuff
78939a1 
- Use com2ann to convert old typing to new
jcklie added a commit that referenced this issue Sep 29, 2021
@jcklie
#192 - Cleanup stuff
af7188e 
- Move to newer add and and_all
jcklie added a commit that referenced this issue Sep 29, 2021
@jcklie
#192 - Cleanup stuff
1174419 
- Silence warnings in places where they are not relevant
jcklie added a commit that referenced this issue Sep 29, 2021
@jcklie
#192 - Cleanup stuff
26fe98c 
- Run pyupgrade
reckart added a commit that referenced this issue Sep 29, 2021
@reckart
Merge branch 'feature/192-cleanup' into feature/168-Experimental-JSON…
1c6c334 
…-CAS-support

* feature/192-cleanup:
  #192 - Cleanup stuff
  #192 - Cleanup stuff
  #192 - Cleanup stuff
  #192 - Cleanup stuff
  #192 - Cleanup stuff
  #192 - Cleanup stuff
  No issue. Fix issues with arrays in cas_to_comparable_text - added missing import.

# Conflicts:
#	cassis/util.py
reckart added a commit that referenced this issue Sep 29, 2021
@reckart
Merge pull request #223 from dkpro/feature/192-cleanup
ea57fc4 
#192 - Clean up stuff
reckart added a commit that referenced this issue Sep 29, 2021
@reckart
#192 - Cleanup stuff
03b14af 
- Run pyupgrade
@reckart reckart modified the milestones: 0.7.0, 0.6.0 Sep 29, 2021
@reckart reckart closed this as completed Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcklie jcklie

Labels
🆕Enhancement
Projects
None yet
Milestone
0.6.0
Development

No branches or pull requests
2 participants
@jcklie @reckart