Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of .line, .column and .location in std.d.parse.simpleParse() #55

Merged
merged 2 commits into from May 20, 2015
Merged

Conversation

ghost
Copy link

@ghost ghost commented May 20, 2015

This modifications are proposed because of #41

  • it doesn't break any previous usage of the AST nodes StaticConstructor and StaticDestructor because the previous member location is not replaced (even if useless since now line and col are more usable).
  • notice that there was a doubt about how-to because it would also be possible to implement the feature specifically for the two items instead of globally, in simpleParse().

Basile Burg added 2 commits May 20, 2015 08:17
line and column info for ASTNode StaticDestructor and StaticConstructor
@Hackerpilot
Copy link
Collaborator

The location field is used by DCD for locating these AST nodes by byte offset. Your approach of adding this feature to simpleParse makes sense.

Hackerpilot added a commit that referenced this pull request May 20, 2015
Handling of .line, .column and .location in std.d.parse.simpleParse()
@Hackerpilot Hackerpilot merged commit b490677 into dlang-community:master May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant