use highlightjs #254
Merged
use highlightjs #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilzbach
force-pushed
the
use_highlighter
branch
3 times, most recently
from
69231c2
to
5bd5865
Compare
|
Wow apparently it's very easy to use CodeMirror to highlight the existing Screenshots are done without #253.
|
Merged
| @@ -106,12 +106,22 @@ dlangTourApp.controller('DlangTourAppCtrl', [ '$scope', '$http', 'hotkeys', func | |||
| hotkeys.add({ | |||
| combo: 'left', | |||
| description: 'Go to previous section', | |||
| callback: prevPage | |||
| callback: function() { | |||
There was a problem hiding this comment.
That doesn't look right. There was a PR which introduced those methods and now they are removed?
wilzbach
force-pushed
the
use_highlighter
branch
4 times, most recently
from
8eca688
to
6dacae1
Compare
wilzbach
force-pushed
the
use_highlighter
branch
from
6dacae1
to
4f88bf8
Compare
The other PR just wasn't part of this one - I don't know why git's suggested auto-merge suggested that, but a simple rebase solved the problem. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up to #253
compare
with:
have a look at e.g.
immutableI realized that highlightjs doesn't recognize attributes correctly, e.g.
hightlight.js:
codemirror:
so probably that's only an intermediate step. Is there a way to use the CodeMirror highlighter for normal
preelements`