Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip meson build #307

Merged
merged 1 commit into from
Sep 13, 2018
Merged

Strip meson build #307

merged 1 commit into from
Sep 13, 2018

Conversation

Geod24
Copy link
Member

@Geod24 Geod24 commented Sep 10, 2018

No description provided.

@dlang-bot dlang-bot added the WIP label Sep 10, 2018
@dlang-bot
Copy link
Collaborator

Thanks for your pull request and interest in making D better, @Geod24! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

@Geod24 Geod24 force-pushed the random branch 2 times, most recently from e3333d5 to 7d74722 Compare September 10, 2018 15:12
@Geod24 Geod24 changed the title [WIP] Print environment variable in use_travis_test_script Strip meson build from libmir/mir-random Sep 10, 2018
@Geod24
Copy link
Member Author

Geod24 commented Sep 10, 2018

Yep, this works and follow dieg-ng's approach.

@Geod24
Copy link
Member Author

Geod24 commented Sep 11, 2018

Well phobos is broken too...

@Geod24
Copy link
Member Author

Geod24 commented Sep 12, 2018

Phobos has been fixed.
kaleidiassociates/lubeck is now broken too because meson was added there too.
So I added them to the list, and simply strip meson. The rationale is that those steps often rely on install, which we do not perform, so any solution would be incomplete.

And our goal is to test D core utils, not the libs themselves.
Maybe in the future we can define a specific config file for those that wish to have their projects build.

@Geod24 Geod24 force-pushed the random branch 3 times, most recently from 3130cbb to 4946c92 Compare September 12, 2018 02:04
@Geod24
Strip any meson tests from travis scripts
867572b 
Stripping meson is preferable for now, as travis config often rely on `install`
step which we do not perform ATM.
This currently affect libmir/mir-random and kaleidicassociates/lubeck
Geod24
Geod24 commented Sep 12, 2018
View reviewed changes
buildkite/build_project.sh
@@ -126,11 +127,6 @@ case "$REPO_FULL_NAME" in
CONFIG=select ./travis-ci.sh
;;

rejectedsoftware/diet-ng)
sed -i '/mkdir build && cd build/,//d' .travis.yml # strip meson tests
use_travis_test_script
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this didn't work and meson was disabled upstream

@Geod24
Copy link
Member Author

Geod24 commented Sep 12, 2018

Ready for a merge. @wilzbach @MartinNowak ?

@Geod24 Geod24 changed the title Strip meson build from libmir/mir-random Strip meson build Sep 13, 2018
@Geod24 Geod24 mentioned this pull request Sep 13, 2018
Merged
@WalterBright WalterBright merged commit aebec46 into dlang:master Sep 13, 2018
@Geod24 Geod24 deleted the random branch September 13, 2018 05:30
@Geod24 Geod24 mentioned this pull request Nov 9, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetarKirov PetarKirov PetarKirov approved these changes

Assignees
No one assigned
Labels
WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Geod24 @dlang-bot @PetarKirov @WalterBright