Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

listen for approve events #104

Closed
wilzbach opened this issue Jun 27, 2017 · 2 comments
Closed

listen for approve events #104

wilzbach opened this issue Jun 27, 2017 · 2 comments
Labels
has PR

Comments

@wilzbach
Copy link
Member

we should immediately run the auto-merge checker if we receive an approve event, e.g.

dlang/dlang.org#1775
@wilzbach
Copy link
Member Author

This requires the hooks to be sent:

image

@wilzbach wilzbach mentioned this issue Jun 27, 2017
Merged
@wilzbach
Copy link
Member Author

Update: I have enabled the pull request review hooks for all relevant dlang repos (+ dlang-bots/dlang-bot and dlang-community/Dscanner)

@wilzbach wilzbach mentioned this issue Jun 27, 2017
Merged
wilzbach added a commit to wilzbach/dlang-bot that referenced this issue Jun 27, 2017
@wilzbach
Fix dlang#104 - listen for approve events
b50d883
wilzbach added a commit to wilzbach/dlang-bot that referenced this issue Jun 27, 2017
@wilzbach
Fix dlang#104 - listen for approve events
4ee5a79
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
has PR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wilzbach