Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chmgen: Emit d.tag in JSON syntax too #1860

Merged
merged 1 commit into from
Aug 8, 2017
Merged

chmgen: Emit d.tag in JSON syntax too #1860

merged 1 commit into from
Aug 8, 2017

Conversation

CyberShadow
Copy link
Member

Partial fix for issue 17731.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @CyberShadow!

Bugzilla references

Auto-close Bugzilla Description
✗ 17731 dman fails to build due to more than 32767 symbols

@CyberShadow
chmgen: Emit d.tag in JSON syntax too
b64a108 
Partial fix for issue 17731.
@CyberShadow CyberShadow mentioned this pull request Aug 8, 2017
Merged
PetarKirov
PetarKirov approved these changes Aug 8, 2017
View reviewed changes
Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, though a bit of explanation in the Makefile about the role of the files would be helpful to future readers.

@wilzbach wilzbach merged commit ba9cd9e into dlang:master Aug 8, 2017
@wilzbach wilzbach mentioned this pull request Jan 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PetarKirov PetarKirov PetarKirov approved these changes

@wilzbach wilzbach wilzbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CyberShadow @dlang-bot @MartinNowak @PetarKirov @wilzbach