Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec/iasm.dd: Expand definition of Register and Register64 #3051

Conversation

CyberShadow
Copy link
Member

@CyberShadow CyberShadow commented Jul 4, 2021

These were previously defined as a set of tokens loosely arranged in a table. Unfortunately, this layout was ambiguous, and if interpreted literally (or by a program) in the same way as the rest of the grammar, they would mean that the tokens on the same line actually have to appear one after another in the source file in the specified order.

As such, we have to sacrifice a bit of human-readability to achieve machine readability. If necessary, the former can be later improved using CSS or additional macros, such as MULTICOLS.

These were previously defined as a set of tokens loosely arranged in a
table. Unfortunately, this layout was ambiguous, and if interpreted
literally (or by a program) in the same way as the rest of the
grammar, they would mean that the tokens on the same line actually
have to appear one after another in the source file in the specified
order.

As such, we gave to sacrifice a bit of human-readability to achieve
machine readability. If necessary, the former can be later improved
using CSS or additional macros, such as MULTICOLS.
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @CyberShadow!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@ibuclaw
Copy link
Member

ibuclaw commented Jul 4, 2021

@CyberShadow do you support iasmgcc grammar in treesitter?

@CyberShadow
Copy link
Member Author

CyberShadow commented Jul 4, 2021

Not yet. Looks like item # 12 here: CyberShadow/tree-sitter-d#3

Would you happen to have a description of the syntax, maybe in the same grammar format as used by the spec?

@ibuclaw
Copy link
Member

ibuclaw commented Jul 4, 2021

Would you happen to have a description of the syntax, maybe in the same grammar format as used by the spec?

Posted in the issue.

@Geod24 Geod24 merged commit 392e229 into dlang:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants