[dmd-cxx] Backport semanticRun refactoring and recursive semantic SEGV bug fixes #10046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @ibuclaw! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "dmd-cxx + dmd#10046" |
ibuclaw
changed the title
thewilsonator
approved these changes
Jun 16, 2019
|
There's a couple apparent regressions, just going to look into them... |
…mantic3done failed
…h override in some cases
ibuclaw
force-pushed
the
dmd-cxx-semantic
branch
from
2472bda
to
5f543c2
Compare
|
There was only one regression, the other was a test missing |
kraj
pushed a commit
to kraj/gcc
that referenced
this pull request
Jun 16, 2019
d/dmd: Merge upstream dmd 792f0fdf2 Fixes segmentation fault in functionParameters, and other related semantic bugs in forward or recursively referenced declarations. Reviewed-on: dlang/dmd#10046 git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@272366 138bc75d-0d04-0410-961f-82ee72b054a4
asiekierka
pushed a commit
to WonderfulToolchain/gcc-ia16
that referenced
this pull request
May 16, 2022
PR d/90603 d/dmd: Merge upstream dmd 792f0fdf2 Fixes segmentation fault in functionParameters, and other related semantic bugs in forward or recursively referenced declarations. Reviewed-on: dlang/dmd#10046 From-SVN: r272366
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are all semi-interdependent on each other leading up to the segfault that I'm wanting to squash.