Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Add setjmp/ucontext definitions for FreeBSD/aarch64 #2269

Merged
merged 1 commit into from
Aug 13, 2018

Conversation

valpackett
Copy link
Contributor

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @myfreeweb! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2269"

@joakim-noah
Copy link
Contributor

Looks like this new submitter needs to be approved on the auto-tester before it will run.

@wilzbach
Copy link
Member

Approved (:

@@ -765,6 +765,38 @@ else version( FreeBSD )
int[6] mc_spare2;
}
}
else version( AArch64 )
{
alias long __register_t;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please use the new alias syntax? (will correct this quickly myself)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ERROR: Permission to myfreeweb/druntime.git denied to wilzbach.

Oh well, it looks like you need to do it yourself or enable maintainer access to your PRs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh the one with the = sign is new? I'm not familiar with D, this is the first D code I'm editing :) I assumed this is the new one since it's more common in that file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, alias __register_t = long is the "new alias syntax".
Unfortunately the old one was never deprecated and as there's still some code that uses it (druntime being a prime example).
We try to avoid using it for new code at least ;-)
Thanks for the fix-up!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants