-
-
Notifications
You must be signed in to change notification settings - Fork 421
Add setjmp/ucontext definitions for FreeBSD/aarch64 #2269
Conversation
Thanks for your pull request and interest in making D better, @myfreeweb! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2269" |
Looks like this new submitter needs to be approved on the auto-tester before it will run. |
Approved (: |
src/core/sys/posix/ucontext.d
Outdated
@@ -765,6 +765,38 @@ else version( FreeBSD ) | |||
int[6] mc_spare2; | |||
} | |||
} | |||
else version( AArch64 ) | |||
{ | |||
alias long __register_t; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please use the new alias syntax? (will correct this quickly myself)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ERROR: Permission to myfreeweb/druntime.git denied to wilzbach.
Oh well, it looks like you need to do it yourself or enable maintainer access to your PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh the one with the =
sign is new? I'm not familiar with D, this is the first D code I'm editing :) I assumed this is the new one since it's more common in that file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, alias __register_t = long
is the "new alias syntax".
Unfortunately the old one was never deprecated and as there's still some code that uses it (druntime being a prime example).
We try to avoid using it for new code at least ;-)
Thanks for the fix-up!
bbfe57c
to
c7854d7
Compare
Tested with ldc ltsmaster.
Relevant headers:
https://github.com/freebsd/freebsd/blob/master/sys/arm64/include/setjmp.h
https://github.com/freebsd/freebsd/blob/master/sys/arm64/include/ucontext.h