Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

[dmd-cxx] Synchronize extern(C) bindings #2741

Merged
merged 1 commit into from
Aug 21, 2019
Merged

[dmd-cxx] Synchronize extern(C) bindings #2741

merged 1 commit into from
Aug 21, 2019

Conversation

ibuclaw
Copy link
Member

@ibuclaw ibuclaw commented Aug 18, 2019

Only parts of note are Musl and Darwin mach.loader.

@ibuclaw ibuclaw added the Trivial typos, formatting, comments label Aug 18, 2019
@dlang-bot
Copy link
Contributor

Thanks for your pull request, @ibuclaw!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "dmd-cxx + druntime#2741"

@ibuclaw
Copy link
Member Author

ibuclaw commented Aug 20, 2019

@Geod24 - rebased.

Copy link
Member

@Geod24 Geod24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no merge right tho.

@ibuclaw
Copy link
Member Author

ibuclaw commented Aug 21, 2019

@Geod24 - Oh well... :-)

@ibuclaw ibuclaw merged commit 5bb8ce1 into dlang:dmd-cxx Aug 21, 2019
@ibuclaw ibuclaw deleted the dmd-cxx-stdc branch August 21, 2019 05:13
@Geod24
Copy link
Member

Geod24 commented Aug 21, 2019

@ibuclaw : So, backtrace & co are not part of Musl, and I doubt they'll get integrated.
On Alpine, libexecinfo provides those symbols. Is there a good way to express this ? In my packages I just link libexecinfo, but open to suggestions.

@ibuclaw
Copy link
Member Author

ibuclaw commented Aug 21, 2019

@Geod24 - In my build, I can see that gcc's in-tree libbacktrace is built, and I can't see it disabled from the system installed gcc either, so I don't think that's a problem.

Configured with: /home/buildozer/aports/main/gcc/src/gcc-8.3.0/configure --prefix=/usr --mandir=/usr/share/man --infodir=/usr/share/info --build=x86_64-alpine-linux-musl --host=x86_64-alpine-linux-musl --target=x86_64-alpine-linux-musl --with-pkgversion='Alpine 8.3.0' --enable-checking=release --disable-fixed-point --disable-libstdcxx-pch --disable-multilib --disable-nls --disable-werror --disable-symvers --enable-__cxa_atexit --enable-default-pie --enable-default-ssp --enable-cloog-backend --enable-languages=c,c++,objc,fortran,ada --disable-libssp --disable-libmpx --disable-libmudflap --disable-libsanitizer --enable-shared --enable-threads --enable-tls --with-system-zlib --with-linker-hash-style=gnu

kraj pushed a commit to kraj/gcc that referenced this pull request Aug 21, 2019
Synchronizes extern(C) bindings with latest release.

Reviewed-on: dlang/druntime#2741

libphobos/ChangeLog:

	* libdruntime/Makefile.am (DRUNTIME_DSOURCES_BIONIC): Add
	core/sys/bionic/string.d.
	(DRUNTIME_DSOURCES_DARWIN): Add core/sys/darwin/string.d.
	(DRUNTIME_DSOURCES_DRAGONFLYBSD): Add core/sys/dragonflybsd/string.d,
	core/sys/dragonflybsd/sys/socket.d.
	(DRUNTIME_DSOURCES_FREEBSD): Add core/sys/freebsd/string.d.
	(DRUNTIME_DSOURCES_LINUX): Add core/sys/linux/string.d.
	(DRUNTIME_DSOURCES_NETBSD): Add core/sys/netbsd/string.d,
	core/sys/netbsd/sys/featuretest.d.
	* libdruntime/Makefile.in: Regenerate.

git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@274773 138bc75d-0d04-0410-961f-82ee72b054a4
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
System Headers Trivial typos, formatting, comments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants