This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Fix Issue 20711 - object.update requires the "update" callback to was… #3012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @CyberShadow! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3012" |
thewilsonator
approved these changes
Mar 31, 2020
…tefully return a copy of the updated value
CyberShadow
force-pushed
the
pull-20200331-050411
branch
from
435223d
to
21c47b3
Compare
|
If I understand the fix is to ensure that if the callback function returns void (i.e its a subroutine in other languages) then no copy of the result needs to be made. In which case the change looks good to me. |
|
Had to rebase as it seems the Buildkite Phobos test does not merge the branch into master before testing. |
omerfirmak
added a commit
to omerfirmak/agora
that referenced
this pull request
Jan 6, 2021
dlang/druntime#3012 seems to be missing in the CI env.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tefully return a copy of the updated value
Also update the examples to illustrate the new, more efficient option.