Fix "dub dustmite" for path based dependencies. Fixes #240. #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes storing the base package for a referenced sub package in the reduction folder. It used to write the package recipe of only the sub package, but now correctly writes the recipe of the full package (base and sub packages).
s-ludwig
force-pushed
the
issue240-dustmite-path-based-deps
branch
from
12be61c
to
c0ce55f
Compare
|
Looks reasonable, but this code has zero test coverage. |
MartinNowak
added a commit
that referenced
this pull request
Mar 20, 2016
…-path-based-deps Fix "dub dustmite" for path based dependencies. Fixes #240.
s-ludwig
added a commit
that referenced
this pull request
Nov 12, 2016
The previous version mixed optional dependency pinning with version pinning logic and missed this case.
s-ludwig
added a commit
that referenced
this pull request
Nov 12, 2016
The previous version mixed optional dependency pinning with version pinning logic and missed this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds handling of path based dependencies to sub packages, as well as path based dependencies of dependencies. Previously, only path based dependencies of the root package god adjusted.