Fix Nullalble to throw logic errors instead of exceptions #1103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also:
http://d.puremagic.com/issues/show_bug.cgi?id=9404
Basically,
Nullable[Flavor]
was not self assignable. Attempts to do self assignement would compile, because it extracts the value value viaget
, and then usesopAssign(T value)
. This can throw an exception if the other nullable is null though.The problem with this is that it makes
this(this) and
opAssign` inconsistent (postblit never throws). This makes things particularly tricky if you start nesting a Nullable inside a struct:This pull simply give all Nullables the function
void opAssign()(typeof(this) other)
. This makes the current nullable a copy of other.Also in this pull: