Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some doc updates for std.array and some more testing #2630

Merged
merged 1 commit into from
Oct 23, 2014

Conversation

burner
Copy link
Member

@burner burner commented Oct 20, 2014

/// Ditto to the resuce and some harder tests

who should I bother to get the page docs up to date?

@burner
Copy link
Member Author

burner commented Oct 20, 2014

I will create some more PRs for std.array similar to this.

@burner burner changed the title some doc updates and some more testing some doc updates for std.array.replace and some more testing Oct 21, 2014
@burner burner changed the title some doc updates for std.array.replace and some more testing some doc updates for std.array and some more testing Oct 21, 2014
@@ -1169,6 +1161,16 @@ void insertInPlace(T, U...)(ref T[] array, size_t pos, U stuff)
}
}

///
unittest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now missing @safe

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will fix it right away

@DmitryOlshansky
Copy link
Member

Otherwise LGTM

moved examples to unittests

DmitryOlshansky fix
@burner
Copy link
Member Author

burner commented Oct 22, 2014

fixed it

@DmitryOlshansky
Copy link
Member

Auto-merge toggled on

DmitryOlshansky added a commit that referenced this pull request Oct 23, 2014
some doc updates for std.array and some more testing
@DmitryOlshansky DmitryOlshansky merged commit 621c762 into dlang:master Oct 23, 2014
@DmitryOlshansky
Copy link
Member

Let it flow )

@burner
Copy link
Member Author

burner commented Oct 24, 2014

Thanks

@burner burner deleted the array_replace_doc branch October 23, 2015 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants