rdmd: Add --include switch #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyberShadow
force-pushed
the
pull-20160412-193525
branch
from
31e8381
to
ab36aa5
Compare
|
LGTM |
| @@ -130,6 +131,7 @@ int main(string[] args) | |||
| "eval", &eval, | |||
| "loop", &loop, | |||
| "exclude", &exclusions, | |||
| "include", (string opt, string p) { exclusions = exclusions.filter!(ex => ex != p).array(); }, | |||
There was a problem hiding this comment.
Hmm how much does this depend on the order of the arguments? I assume if you ran:
--exclude=abc --include=abc
abc would be included at the end. This is more of a question for getopt, since I'm not sure whether it iterates arguments left-to-right or right-to-left.
There was a problem hiding this comment.
Ok I've confirmed it actually iterates over the options in order first, not the arguments. So the PR is ok.
|
LGTM, could add a changelog entry as well. :) |
|
Is there a bugzilla issue? |
|
Thanks Andrej :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.