fix issue 16966 - rdmd: AssertError@rdmd.d(489): should have been cre… #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated by compileRootAndGetDeps
|
andralex
approved these changes
Dec 22, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ated by compileRootAndGetDeps
The bug:
On the first run everything is fine.
On the second run,
compileRootAndGetDepslooks at rdmd.deps to decide if it needs to compile the root module. rdmd.deps is present from the first build, so it looks like everything is up to date and there's apparently no reason to rebuild the root module. But the specified executable doesn't exist, so some code inmaincorrectly decides that a rebuild is needed. The build cannot succeed without the root object, of course.This fix:
I'm passing
main'slastBuildTimetocompileRootAndGetDepsand check there if the root module needs to be compiled even when the dependencies don't need to be obtained.That complicates
compileRootAndGetDepssome more. I'm not really happy with my fix here, but I can't seem to come up with something nicer. rdmd could probably use some refactorings.