Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue 17198 - rdmd does not recompile when --extra-file is added #218

Closed
wants to merge 1 commit into from

Conversation

aG0aep6G
Copy link
Contributor

No description provided.

@dlang-bot
Copy link
Contributor

Fix Bugzilla Description
17198 rdmd does not recompile when --extra-file is added

@dlang-bot dlang-bot added the Type.Bug Things don't work as they were intended to, or the way they were intended to work doesn't make sense label Feb 20, 2017
@wilzbach
Copy link
Member

@aG0aep6G to iterate what Martin is trying to say for the last year:

All bug fixes should go into stable

(for the point releases the stable branch will be used)

We are currently trying to work out a way to let the DLang-Bot warn you in such cases - see e. g. dlang/dlang-bot#8 if you are interested.

Another idea would be to let the Dlang-Bot trigger a similar PR for stable once a bug fix arrives in master (or the other way around): https://github.com/dlang-bots/dlang-bot/issues

@aG0aep6G
Copy link
Contributor Author

All bug fixes should go into stable

Ugh, GitHub should really let me change the target branch of a pull request. It's so easy to forget. Anyway, here it is against stable: #219.

@aG0aep6G aG0aep6G closed this Feb 20, 2017
@wilzbach
Copy link
Member

@aG0aep6G
Copy link
Contributor Author

They do since last summer: https://github.com/blog/2224-change-the-base-branch-of-a-pull-request

Double dukes. You have to click the "Edit" button next to the title to make that drop-down list appear. Didn't occur to me. Well, let's just go with #219 now :|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type.Bug Things don't work as they were intended to, or the way they were intended to work doesn't make sense
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants