Add customerId to gesture path #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't currently used in code execution but keeps paths consistent and gives scope to use later if required
donaldgray
force-pushed
the
feature/gesture_path
branch
from
97f332d
to
1612c1b
Compare
JackLewis-digirati
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
customerIdvalue isn't currently used in code execution but keeps paths consistent and gives scope to use later if requiredGesture path was previously
/auth/v2/access/gesture.This change makes it
/auth/v2/access/{customerId}/gesturewhich keeps it aligned with other paths, which makes configuring bulk rewrite rules easier. E.g./auth/v2/access/{customerId}/{accessServiceName}/auth/v2/access/{customerId}/{accessServiceName}/logoutOverriding the default value is done via appSettings rather than DB settings, this can be changed later if required. Note that the values configured in appSettings must contain the
pathBasevalue, it felt wrong to force it to be picked up as the alternative route format may exclude it.