Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Charts] Handle refunds #85

Closed
dlebech opened this issue Dec 1, 2018 · 0 comments
Closed

[Charts] Handle refunds #85

dlebech opened this issue Dec 1, 2018 · 0 comments

Comments

@dlebech
Copy link
Owner

dlebech commented Dec 1, 2018

When an item is refunded, the original expense is still the only thing showing up in expenses overview. This leads to an incorrect view of expenses.

  1. The easiest option to fix this is to simply include all transaction amounts in the expenses sum charts, but ignore categories where the sum is positive (this should automatically exclude actual income). The problem with this approach is if the expense and refund transactions happen far apart. Then their grouped sums will be in separate months, and it won't work.
  2. Add a way to tag something as a refund to something else. This seems to be the proper approach, as it will also allow partial refunds in a good way.
@dlebech dlebech mentioned this issue Dec 2, 2018
dlebech added a commit that referenced this issue Dec 2, 2018
This commit consist of three parts:
- Actions: An action to delete a transaction group
- Transaction List: An indicator on the transaction list that
  transactions are grouped (and a method to ungroup them)
- Charts: Summing and filtering of transactions that are grouped
  together

This feature is implemented as a way to handle refunds, i.e. avoid
having refunds show up as both an expense and income

Closes #85 and closes #87
@dlebech dlebech closed this as completed in 3404277 Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant