Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add currencies to charts #66

Merged
merged 5 commits into from
Oct 14, 2018
Merged

Add currencies to charts #66

merged 5 commits into from
Oct 14, 2018

Conversation

dlebech
Copy link
Owner

@dlebech dlebech commented Oct 14, 2018

Closes #55

@codecov
Copy link

codecov bot commented Oct 14, 2018

Codecov Report

Merging #66 into master will increase coverage by 1.56%.
The diff coverage is 93.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   72.34%   73.91%   +1.56%     
==========================================
  Files          56       58       +2     
  Lines        1074     1150      +76     
==========================================
+ Hits          777      850      +73     
- Misses        297      300       +3
Impacted Files Coverage Δ
src/reducers/app.js 85.71% <ø> (-6.6%) ⬇️
src/components/Transactions.js 48.97% <ø> (ø) ⬆️
src/reducers/edit.js 100% <100%> (ø) ⬆️
src/components/transactions/TransactionRow.js 84.21% <100%> (ø) ⬆️
src/lambda/currencyRates.js 100% <100%> (ø) ⬆️
src/util.js 84.26% <100%> (+1.55%) ⬆️
src/lambda/currencies.js 100% <100%> (ø) ⬆️
src/lambda/eurofx/index.js 100% <100%> (ø) ⬆️
src/components/charts/AmountCard.js 100% <100%> (ø) ⬆️
src/components/charts/CategoryTreeMap.js 77.77% <77.77%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27f9525...0042f05. Read the comment docs.

@dlebech dlebech merged commit d1f673a into master Oct 14, 2018
@dlebech dlebech deleted the add-currencies-to-charts branch October 14, 2018 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant