gp_saml_gui.py: ensure that proxies are disabled #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While that's a common use case, it's also not unheard-of that VPN users have to go through a proxy to access the VPN server. (It's a dumb and inefficient setup, but I've heard of it repeatedly with different corporate VPNs.) Perhaps you could put this behind a |
dlenski
requested changes
Jan 5, 2024
dlenski
reviewed
Mar 7, 2024
dlenski
reviewed
Mar 7, 2024
mchehab
force-pushed
the
master
branch
2 times, most recently
from
d397050
to
9a1cac9
Compare
|
@dlenski - anything pending on this? We have several people who would benefit from this being added. We're working on some other workarounds in the meantime, but this would go a long way to resolving. |
Instead of needing to manually add all arguments manually, pass the argument dict directly to SAMLLoginView class.
Using a proxy while trying to connect to VPN can be problematic, as proxies are usually behind the VPN. So, add an option to disable it when opening the WebKit window.
dlenski
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a proxy while trying to connect to VPN is problematic, as proxies are usually behind the VPN.
So, disable it when opening the WebKit window.