resolve to absolute path #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ubuntu 22.10 /etc/resolv.conf resolves to ../run/systemd/resolve/stub-resolv.conf so it does not match the regex. So, it is better to use the absolute path.
|
I have the same issue with ubuntu 22.04. |
|
any comment on this PR? it is needed since ubuntu 22.04 and it works in ubuntu 23.04 also, I just tested it. Can we merge it? |
|
Indeed, it would be great to have this merged for Ubuntu 22.04. |
This was referenced May 6, 2023
dlenski
pushed a commit
that referenced
this pull request
Jul 6, 2023
In ubuntu 22.10 /etc/resolv.conf resolves to ../run/systemd/resolve/stub-resolv.conf so it does not match the regex. So, it is better to use the absolute path. [ DRL: cherry-pick of #126 ]
|
Thanks. On the mainline branch, I've reverted #118 in a640258. I've created a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ubuntu 22.10 /etc/resolv.conf resolves to ../run/systemd/resolve/stub-resolv.conf so it does not match the regex.
So, it is better to use the absolute path.