[improve] Handle PositionInfo that's too large to serialize as a single entry #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlg99
changed the title
15 tasks
dlg99
force-pushed
the
cpick/cursor-large-state
branch
from
6fd14cc
to
319ad5f
Compare
dlg99
force-pushed
the
cpick/cursor-large-state
branch
from
319ad5f
to
1c405fe
Compare
(cherry picked from commit 1ef9664)
* serialize/compress without intermediate byte arrays * use lightproto for cursor serialization to the ledger * Reuse PositionInfo (cherry picked from commit 1887c44)
(cherry picked from commit 98a3d25)
* ManagedCursor: manually serialise PositionInfo * Add tests and save last serialized side to prevent reallocations (cherry picked from commit 8a365d0)
(cherry picked from commit 44ba614)
(cherry picked from commit f1323c6)
(cherry picked from commit d4b94ab)
(cherry picked from commit 5f07f0c)
(cherry picked from commit 6d2e494)
…pache#275) (cherry picked from commit 6a2a010)
(cherry picked from commit 4c5387d)
(cherry picked from commit c3fe80e)
…footer of the chunked data (apache#282) (cherry picked from commit 6e72ecb)
dlg99
force-pushed
the
cpick/cursor-large-state
branch
from
1c405fe
to
1397faf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In some cases cursor position info can be too large to serialize as a single entry, e.g. in case of too many deleted ranges. Also the serialization can be too slow.
cherry-picks of changes by @eolivelli @nicoloboschi and I.
Modifications
Cursor PositionInfo serialization is reworked to produce less garbage/serialize faster; serialized data can be compressed.
In case the serialized data too large it is chunked and saved as a sequence of entries.
Verifying this change
This change added tests.
Does this pull request potentially affect one of the following parts:
NO
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-completeMatching PR in forked repository
PR in forked repository: