-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for colo(u)r table with first entry as transparency #5
Conversation
The banana looks great 👍 |
We are looking into your PR. There are a few things that we will check to make sure it is consistent with all the other flags. |
…n the frame before
Looks good.
In order to resolve these issues some rework would be required on how CGIF writes individual frames: Are you aware of any GIFs that mix transparent and regular frames? I would think that is rather uncommon. |
For the purposes of libvips integration, making Rather than a frame-level setting, perhaps we should shift If the attribute were to remain at frame level, it might be that the API should then allow for fine-grained control over the disposal method e.g. |
Yes, moving this flag to a |
Guten Tag, I've taken the approach as suggested in #4, ensuring the relevant disposal method is set, plus added a unit test.
I've also tested this using a botched together libvips+cgif integration and the obligatory dancing banana.