Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for interlaced encoding #50

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Add support for interlaced encoding #50

merged 2 commits into from
Apr 19, 2022

Conversation

dloebl
Copy link
Owner

@dloebl dloebl commented Apr 17, 2022

Add support for encoding frames interlaced: CGIF_FRAME_ATTR_INTERLACED
Interlaced GIF frames are encoded using a progressive pattern in 4 passes.

@dloebl dloebl added the enhancement New feature or request label Apr 17, 2022
@dloebl dloebl requested a review from MCLoebl April 17, 2022 18:51
MCLoebl
MCLoebl previously approved these changes Apr 19, 2022
View reviewed changes
Copy link
Collaborator

@MCLoebl MCLoebl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's maybe add another test with a horizontal line pattern. Aliasing upon loading the image would demonstrate that the interlacing works.

@dloebl dloebl requested a review from MCLoebl April 19, 2022 20:10
@dloebl dloebl merged commit b05de32 into main Apr 19, 2022
@dloebl dloebl deleted the interlaced branch April 20, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MCLoebl MCLoebl Awaiting requested review from MCLoebl

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dloebl @MCLoebl