Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added documentation for the usage of the dependency-checker too… #30

Merged
merged 1 commit into from
Aug 4, 2020

Conversation

MichaelLangbein
Copy link
Collaborator

@MichaelLangbein MichaelLangbein commented Aug 4, 2020

…l. Only affects demo-maps. Handles issue #19

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

The project demo-maps has a route licenses. This route displays a component with a list of all the licenses that are being used in the project. That list is being generated with a CLI tool named license-checker.

Issue Number: 19

What is the new behavior?

The usage of license-checker has been documented extensively. After some discussion, it was decided to not include the tool in the standard-build-process, because that would add another dependency for us to manage. Instead documentation has been provided to help consumers of the frontend-libraries to integrate the tool in their own build-process.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

This PR affects only the project demo-maps.

@MichaelLangbein MichaelLangbein linked an issue Aug 4, 2020 that may be closed by this pull request
@boeckMt boeckMt merged commit 9309665 into master Aug 4, 2020
@boeckMt boeckMt deleted the licenses branch August 4, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update licenses route in demo-maps
2 participants