Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes bug, where configs where not injected for async functions #1241

Merged
merged 1 commit into from Apr 18, 2024

Conversation

sh-rp
Copy link
Collaborator

@sh-rp sh-rp commented Apr 18, 2024

Description

Fixes signature discovery for async functions.

@sh-rp sh-rp requested a review from rudolfix April 18, 2024 11:41
@sh-rp sh-rp self-assigned this Apr 18, 2024
Copy link

netlify bot commented Apr 18, 2024

Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 6a4d467
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/662107c88840200007b55213

@sh-rp sh-rp force-pushed the d#/allow_signature_discovery_async branch from a3c32e2 to 6a4d467 Compare April 18, 2024 11:45
@sh-rp sh-rp marked this pull request as ready for review April 18, 2024 11:45
@sh-rp sh-rp linked an issue Apr 18, 2024 that may be closed by this pull request
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! LGTM!

@rudolfix rudolfix merged commit 89b8da5 into devel Apr 18, 2024
47 of 48 checks passed
@rudolfix rudolfix deleted the d#/allow_signature_discovery_async branch May 20, 2024 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

config and secrets do not work on async resource
2 participants