Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typing classifier and update maintainers in pyproject #1391

Merged
merged 1 commit into from
May 24, 2024

Conversation

sh-rp
Copy link
Collaborator

@sh-rp sh-rp commented May 21, 2024

Description

Adds missing typing classifier and updates maintainers in pyproject

update maintainers
@sh-rp sh-rp requested a review from rudolfix May 21, 2024 11:43
Copy link

netlify bot commented May 21, 2024

Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 9d5fa0c
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/664c88e1c01e76000815b899
😎 Deploy Preview https://deploy-preview-1391--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
are authors e-mails? we should probably say that authors are dlt contributors as per apache license. but that's a minor issue

@sh-rp
Copy link
Collaborator Author

sh-rp commented May 21, 2024

@rudolfix I'm not sure what your proposed change is exactly. Put the maintainers as authors and add a comment in the license or what do you have in mind?

@rudolfix
Copy link
Collaborator

@sh-rp nvm. I should stop adding non-actionable thoughts :)

@rudolfix rudolfix marked this pull request as ready for review May 24, 2024 10:53
@rudolfix rudolfix merged commit 7c07c67 into devel May 24, 2024
47 of 50 checks passed
@rudolfix rudolfix deleted the feat/pyproject_updates branch May 24, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants