-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Grammar files 20-40 #1847
Conversation
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, so it did change code snippets in a few places. In all but one it's actually pretty good changes, I'm impressed!
f"in {m.time}" + | ||
f"with status {m.status}" + | ||
f"and message {m.message}" | ||
f" in {m.time}" + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sh-rp one thing we asked chat-gpt not to do :c
it's fixing code :c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, strange..
@@ -335,6 +336,8 @@ export DESTINATION__FILESYSTEM__CREDENTIALS__AWS_SECRET_ACCESS_KEY="api_key" | |||
```py | |||
import os | |||
import dlt | |||
import botocore.session | |||
from dlt.common.credentials import AwsCredentials |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks nice, but dangerous territory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but the change is good :D
Co-authored-by: Violetta Mishechkina <sansiositres@gmail.com>
Co-authored-by: Violetta Mishechkina <sansiositres@gmail.com>
Co-authored-by: Violetta Mishechkina <sansiositres@gmail.com>
0963c75
to
0db50a3
Compare
Description
Grammar checker run for files 20-40