Docs: Grammar files 20-40 #1847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
VioletM
requested changes
Sep 20, 2024
| f"in {m.time}" + | ||
| f"with status {m.status}" + | ||
| f"and message {m.message}" | ||
| f" in {m.time}" + |
There was a problem hiding this comment.
@sh-rp one thing we asked chat-gpt not to do :c
it's fixing code :c
| @@ -335,6 +336,8 @@ export DESTINATION__FILESYSTEM__CREDENTIALS__AWS_SECRET_ACCESS_KEY="api_key" | |||
| ```py | |||
| import os | |||
| import dlt | |||
| import botocore.session | |||
| from dlt.common.credentials import AwsCredentials | |||
There was a problem hiding this comment.
This looks nice, but dangerous territory
There was a problem hiding this comment.
I agree, but the change is good :D
Co-authored-by: Violetta Mishechkina <sansiositres@gmail.com>
Co-authored-by: Violetta Mishechkina <sansiositres@gmail.com>
Co-authored-by: Violetta Mishechkina <sansiositres@gmail.com>
sh-rp
force-pushed
the
docs/gramma-20-40
branch
from
0963c75
to
0db50a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Grammar checker run for files 20-40