Allows any duckdb version, fixes databricks az credentials #1854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
rudolfix
force-pushed
the
fix/1828-1853-fixes-duckdb-databricks
branch
from
2a2efbc
to
f2b4793
Compare
sh-rp
reviewed
Sep 24, 2024
| @@ -41,3 +45,13 @@ def verify_normalized_table( | |||
| f"`{table['table_format']}` for table `{table['name']}`. " | |||
| "The setting will probably be ignored." | |||
| ) | |||
|
|
|||
| parent_key = get_first_column_name_with_prop(table, "parent_key") | |||
| if parent_key and not is_nested_table(table): | |||
There was a problem hiding this comment.
we could consider cleaning up these kind of problems automatically, no?
There was a problem hiding this comment.
IMO in 90% this is user trying their own table structure...
sh-rp
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #1853
fixes #1828
fixes #1839