Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a suffix to the default dataset name #207

Merged
merged 2 commits into from
Mar 29, 2023
Merged

Add a suffix to the default dataset name #207

merged 2 commits into from
Mar 29, 2023

Conversation

burnash
Copy link
Collaborator

@burnash burnash commented Mar 28, 2023

Resolves the linked issue by adding a _dataset suffix to a dataset name derived from pipeline name.

Fixes #176

@netlify
Copy link

netlify bot commented Mar 28, 2023 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit f1782e9
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/642315e42a07c30008967613

@burnash burnash requested a review from rudolfix March 28, 2023 16:17
rudolfix
rudolfix approved these changes Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good and thanks for the tests!

@burnash burnash merged commit dbd890a into devel Mar 29, 2023
@rudolfix rudolfix deleted the fix/ambiguous_db_reference branch March 30, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolfix rudolfix rudolfix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

catalog mixed with schema on duckdb 0.7.x
2 participants
@burnash @rudolfix