Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Broken image in Docs > Pipelines > Google Analytics #328

Merged
merged 1 commit into from
May 16, 2023
Merged

Fix Broken image in Docs > Pipelines > Google Analytics #328

merged 1 commit into from
May 16, 2023

Conversation

tungbq
Copy link
Contributor

@tungbq tungbq commented May 10, 2023 •
edited
Loading

Fixes: #326
Analysis:

  • The markdown file in our repo using relative path so it will not be break in the repo scope
  • But once we render that markdown file elsewhere, the relative path might not exists on the server. So, it will not get the correct image source.

Solution:

Result from draft PR Deploy Preview:

image

@netlify
Copy link

netlify bot commented May 10, 2023 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs ready!

Name Link
🔨 Latest commit 28329b9
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/645bcea4d21ccb00088e5f2c
😎 Deploy Preview https://deploy-preview-328--dlt-hub-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@tungbq tungbq marked this pull request as ready for review May 10, 2023 17:11
@tungbq tungbq mentioned this pull request May 10, 2023
Closed
@rudolfix rudolfix merged commit 46d28fb into dlt-hub:devel May 16, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahuljo rahuljo rahuljo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken image in Docs > Pipelines > Google Analytics
3 participants
@tungbq @rahuljo @rudolfix