Fix/incremental with timezone naive datetime #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for dlt-hub-docs canceled.
|
steinitzu
force-pushed
the
fix/incremental-tz-naive-datetime
branch
from
6edbd9b
to
ad39213
Compare
rudolfix
requested changes
May 11, 2023
rudolfix
approved these changes
May 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cast all datetimes to pendulum before doing incremental comparison. Fixes error when the row value is a timezone naive python datetime.
The state value always deserializes to tz aware pendulum datetime. But sql db resources return python datetimes with or without timezone.
Second commit with the json fix is unrelated, spotted it when testing :)