Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dbt 1.5 support #475

Merged
merged 5 commits into from
Jul 8, 2023
Merged

dbt 1.5 support #475

merged 5 commits into from
Jul 8, 2023

Conversation

sh-rp
Copy link
Collaborator

@sh-rp sh-rp commented Jul 6, 2023 •
edited by rudolfix
Loading

closes #458

@sh-rp sh-rp changed the title D#/dbt 1.5 support dbt 1.5 support Jul 6, 2023
@netlify
Copy link

netlify bot commented Jul 6, 2023 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 09b5dc8
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/64a6e05d25dba2000861dad9

@sh-rp sh-rp marked this pull request as ready for review July 6, 2023 15:16
rudolfix
rudolfix requested changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks really good!
pls look at the ticket: #458

  • we bump default dbt version
  • please test if Motherduck works with dbt (you can mock tests to use motherduck instead of duck db and see if they work locally). then update motherduck destination docs

rudolfix
rudolfix approved these changes Jul 8, 2023
View reviewed changes
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sh-rp let's merge this because there's another PR growing (#478 ) that messes up with dbt runner a little

@rudolfix rudolfix merged commit d268701 into devel Jul 8, 2023
36 checks passed
@rudolfix rudolfix deleted the d#/dbt_1.5_support branch July 8, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolfix rudolfix rudolfix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable dbt 1.5.0
2 participants
@sh-rp @rudolfix