Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dlt init version check #514

Merged
merged 9 commits into from
Jul 26, 2023
Merged

dlt init version check #514

merged 9 commits into from
Jul 26, 2023

Conversation

steinitzu
Copy link
Collaborator

Implements: #241

@netlify
Copy link

netlify bot commented Jul 25, 2023 •
edited
Loading

✅ Deploy Preview for dlt-hub-docs canceled.

Name Link
🔨 Latest commit 397af82
🔍 Latest deploy log https://app.netlify.com/sites/dlt-hub-docs/deploys/64c16a7b61a126000801f50d

@steinitzu steinitzu changed the title Sthor/dlt init version check dlt init version check Jul 25, 2023
@steinitzu steinitzu marked this pull request as draft July 25, 2023 18:41
@steinitzu steinitzu marked this pull request as ready for review July 25, 2023 23:39
@steinitzu steinitzu requested a review from rudolfix July 26, 2023 02:38
rudolfix
rudolfix approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@rudolfix rudolfix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent! also I've checked manually a few mocked cases and all seems to work

@rudolfix rudolfix merged commit 3fb1f6d into devel Jul 26, 2023
35 checks passed
@rudolfix rudolfix deleted the sthor/dlt-init-version-check branch July 26, 2023 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rudolfix rudolfix rudolfix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@steinitzu @rudolfix